Repository navigation
Conversation
SomeeName
marked this pull request as draft
October 21, 2026 16:14
…chords with more than 6 strings
SomeeName
marked this pull request as ready for review
October 21, 2026 16:55
SomeeName
marked this pull request as draft
October 23, 2026 06:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal for potentially supporting 7 string Rocksmith charts with https://github.com/SomeeName/rs7string
Tuning and chord templates can now keep seven strings, with the low B stored at index 6, so existing six string charts shouldn't be affected.
StringLayouthandles the difference between storage order and the actual string order.Dynamic difficulty generation and arrangement checks also account for the extra string.
A tuning is only read as seven strings when it has
strings="7", orstring6without astringsattribute. Charter writesstring6-string8as copies ofstring5on every arrangement, so its six string files stay six strings. Tunings with more than seven strings are rejected, and SNG chord templates stay six wide.This does not add playable seven-string export yet.
Tests: XML 71, Conversion 75, DLCProject 106, DD 35, XML.Processing 165, all passing.